Force TLS 1.2 #49
Merged
Force TLS 1.2 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of relying on Windows having necessary TLS version setup properly. Force correct version at run-time. bump version 1.5.3 force btnBrowse to be active control Without defining active control btnCancel was being selected at run-time. Pressing enter would cause installer to exit. replace literals with enumerated values Remove Check TLS Version code add exception handler if RESTRequest1 should raise an exception lets capture it and allow the installer to exit gracefully instead of appearing to be hung.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #48
Instead of relying on Windows having necessary TLS version setup properly. Force correct version at run-time.
bump version 1.5.3
force btnBrowse to be active control
Without defining active control btnCancel was being selected at run-time. Pressing enter would cause installer to exit.
replace literals with enumerated values
Remove Check TLS Version code
add exception handler
if RESTRequest1 should raise an exception lets capture it and allow the installer to exit gracefully instead of appearing to be hung.