Fix creation issue with Exercises #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iHiD
changed the title
We could leave it out, although it also doesn't really hard. Setting the status to wip here would interfere with #1659 |
ErikSchierboom
force-pushed
the
fix-syncing
branch
from
0a16c91 to
f7a8696
Compare
ErikSchierboom
changed the title
|
@iHiD I've updated the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ErikSchierboom We need to force_sync for new exercises to get the authors/contributors to create. I think this needs copying for both types of exercises and concept, and tests adding.
This also guarantees we don't don't issues like the test_runner stauts one from before (in fact we could now actively leave that field out in this bit if we wanted, and set the exercise's status here to
wipand let the force_sync set the right values)