Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

Add myself to v3 javascript/maintainers.md #62

Merged
merged 2 commits into from
Jan 15, 2020

Conversation

Calamari
Copy link
Contributor

No description provided.

@Calamari Calamari requested a review from a team as a code owner January 15, 2020 18:12
@@ -8,4 +8,4 @@ TODO: add senior maintainers

## Contributing Maintainers

TODO: add contributing maintainers
- Georg Tavonius (Slack: @Georg Tavonius, GitHub: Calamari)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Georg Tavonius (Slack: @Georg Tavonius, GitHub: Calamari)
- Georg Tavonius (Slack: @Georg Tavonius, GitHub: [Calamari](https://github.com/calamari))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a link is nicer 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I copied the style from another file, but does not mean we cannot improve it

Copy link
Member

@tehsphinx tehsphinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we really be doing this before any contribution has been made?

@tehsphinx
Copy link
Member

tehsphinx commented Jan 15, 2020

All new maintainers were asked to do this... probably for communication purposes.

@SleeplessByte
Copy link
Member

@tehsphinx yeah, @iHiD just informed us :)

@SleeplessByte SleeplessByte merged commit e1fdd8b into exercism:master Jan 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants