Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

[C#] string-formatting new exercise #1871

Merged
merged 58 commits into from
Jul 21, 2020
Merged

[C#] string-formatting new exercise #1871

merged 58 commits into from
Jul 21, 2020

Conversation

mikedamay
Copy link
Contributor

No description provided.

mikedamay and others added 30 commits June 9, 2020 13:22
@mikedamay
csharp/tuples first shot
ddf392e
@mikedamay
csharp/tuples aligned with latest document formatting
8b69ccc
@mikedamay
tweaked design doc
5315785
@mikedamay
csharp/tuples after.md
e32a4f0
@mikedamay
Merge remote-tracking branch 'origin/csharp/tuples' into csharp/tuples
c34f998
@mikedamay
csharp/tuples introduction.md
c2b7588
@mikedamay
csharp/tuples tweaks to introduction.md
7d3d87e
@mikedamay
csharp/tuples tweak to introduction.md
d9a04ea
@mikedamay
csharp/tuples fixed typos in instructions.md
9e828ed
@mikedamay
added exercise template
e0b4444
@mikedamay
csharp/tuples tweaks
a9861e3
@mikedamay @ErikSchierboom
Apply suggestions from code review
8c16740 
Co-authored-by: Erik Schierboom <[email protected]>
@mikedamay
csharp/tuples after review
174e65e
@mikedamay
csharp/tuples after review
b3bf8df
@mikedamay
Merge branch 'master' into csharp/tuples
f31c1aa
@mikedamay @ErikSchierboom
Apply suggestions from code review
bde2ce9 
Co-authored-by: Erik Schierboom <[email protected]>
@mikedamay
csharp/tuples late review
a49ca43
@mikedamay
csharp/tuples missed reveiew point
87e9a63
@mikedamay
csharp/tuples missed reveiew point
a1de61a
@mikedamay @ErikSchierboom
Apply suggestions from code review
e19e1ec 
Co-authored-by: Erik Schierboom <[email protected]>
@mikedamay
Merge branch 'csharp/tuples'
80caa85
@mikedamay
Merge remote-tracking branch 'canonical/master'
b551f13
@mikedamay
Merge remote-tracking branch 'canonical/master'
86f845e
@mikedamay
Merge remote-tracking branch 'canonical/master'
44c8668
@mikedamay
csharp/concept-doc updated equality, tuples, randomness
9bfcb00
@mikedamay
master - put aa-template in its own branch
8f7b406
@mikedamay
resolve merge conflicts
594c967
@mikedamay
Merge remote-tracking branch 'canonical/master'
afe157e
@mikedamay
Merge remote-tracking branch 'canonical/master'
b8aae5c
@mikedamay
Merge remote-tracking branch 'canonical/master'
3aa329a
@mikedamay
Copy link
Contributor Author

closed while finalizing - will reopen shortly

@mikedamay mikedamay closed this Jul 13, 2020
@mikedamay mikedamay reopened this Jul 13, 2020
@mikedamay
Copy link
Contributor Author

All files complete and proofed except csharp/config.json which I will add before pushing

@mikedamay mikedamay marked this pull request as ready for review July 13, 2020 16:25
wolf99
wolf99 reviewed Jul 13, 2020
View reviewed changes
Copy link
Contributor

@wolf99 wolf99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool 😎
just a few small comments/questions

languages/csharp/exercises/concept/string-formatting/.docs/introduction.md Outdated Show resolved Hide resolved
languages/csharp/exercises/concept/string-formatting/.docs/introduction.md Show resolved Hide resolved
languages/csharp/exercises/concept/string-formatting/.docs/introduction.md Show resolved Hide resolved
@mikedamay
Copy link
Contributor Author

@wolf99 Thank you for the comments. Much appreciated.

@ErikSchierboom
Copy link
Member

I'll look at the latest version tomorrow.

@mikedamay
Copy link
Contributor Author

Interesting. I think a couple of comments I made disappeared (since redone) - about the time Github had one of its conniptions. Although, I suppose I'm perfectly capable of clicking on the Comment button.

wolf99
wolf99 approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@wolf99 wolf99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mikedamay
Copy link
Contributor Author

Thanks

@mikedamay mikedamay merged commit 8112186 into exercism:master Jul 21, 2020
@mikedamay mikedamay deleted the csharp/string-formatting2 branch July 21, 2020 03:42
@mikedamay mikedamay mentioned this pull request Jul 21, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

@wolf99 wolf99 wolf99 approved these changes

Assignees
No one assigned
Labels
track/csharp type/new-exercise Add a new exercise
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikedamay @ErikSchierboom @wolf99