Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try out danger via Github Actions #290

Closed
wants to merge 5 commits into from

Conversation

SleeplessByte
Copy link
Member

Another try-out. If this works, merge into #289

@SleeplessByte SleeplessByte self-assigned this Oct 14, 2019
@SleeplessByte SleeplessByte changed the base branch from chore/github-actions to master October 14, 2019 13:55
Committing to try to trigger action
@pacman-bot
Copy link

pacman-bot commented Oct 14, 2019

8 Messages
📖 ../../../../runner/work/typescript/typescript/exercises/atbash-cipher/atbash-cipher.example.ts#L2 - Type string trivially inferred from a string literal, remove type annotation. (@typescript-eslint/no-inferrable-types)
📖 ../../../../runner/work/typescript/typescript/exercises/atbash-cipher/atbash-cipher.example.ts#L3 - Type string trivially inferred from a string literal, remove type annotation. (@typescript-eslint/no-inferrable-types)
📖 ../../../../runner/work/typescript/typescript/exercises/beer-song/beer-song.example.ts#L28 - Type number trivially inferred from a number literal, remove type annotation. (@typescript-eslint/no-inferrable-types)
📖 ../../../../runner/work/typescript/typescript/exercises/clock/clock.example.ts#L5 - Type number trivially inferred from a number literal, remove type annotation. (@typescript-eslint/no-inferrable-types)
📖 ../../../../runner/work/typescript/typescript/exercises/pangram/pangram.example.ts#L7 - Type string trivially inferred from a string literal, remove type annotation. (@typescript-eslint/no-inferrable-types)
📖 ../../../../runner/work/typescript/typescript/exercises/pythagorean-triplet/pythagorean-triplet.example.ts#L35 - Type number trivially inferred from a number literal, remove type annotation. (@typescript-eslint/no-inferrable-types)
📖 ../../../../runner/work/typescript/typescript/exercises/robot-simulator/robot-simulator.example.ts#L5 - Type number trivially inferred from a number literal, remove type annotation. (@typescript-eslint/no-inferrable-types)
📖 ../../../../runner/work/typescript/typescript/exercises/robot-simulator/robot-simulator.example.ts#L5 - Type string trivially inferred from a string literal, remove type annotation. (@typescript-eslint/no-inferrable-types)

Generated by 🚫 Danger

@SleeplessByte
Copy link
Member Author

Let me also convert to danger-js (using typescript), as this is the typescript repo.

https://danger.systems/js/guides/getting_started.html#including-danger

@SleeplessByte
Copy link
Member Author

Things to do:

  • fix paths
  • use danger-js (with typescript)
  • fix exit code to PR status (block on exit code != 0)

@SleeplessByte SleeplessByte deleted the chore/github-actions-danger branch February 6, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants