Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 8th #1

Merged
merged 8 commits into from
Nov 3, 2023
Merged

Add support for 8th #1

merged 8 commits into from
Nov 3, 2023

Conversation

glennj
Copy link

@glennj glennj commented Nov 1, 2023

@glennj
Copy link
Author

glennj commented Nov 1, 2023

@ErikSchierboom CI not launching for PRs?

@ErikSchierboom
Copy link
Member

That's weird. I'll look into it!

@ErikSchierboom
Copy link
Member

Found it. They should be enabled now. Could you add an empty commit or something to test?

@glennj
Copy link
Author

glennj commented Nov 1, 2023

"8th" broke it, starting with a digit

@glennj
Copy link
Author

glennj commented Nov 1, 2023

Lots of checks getting cancelled, lots failing.
Do we really need to run on so many architectures? Surely the Exercism infrastructure is only using one specific build.

@ErikSchierboom
Copy link
Member

Do we really need to run on so many architectures? Surely the Exercism infrastructure is only using one specific build.

We don't. I'll update tomorrow. It's just that I want to make as few changes as possible to the original code, for easy of updating this fork from its source. I might disable these workflows and then add a new one that's specific to this repo.

@ErikSchierboom
Copy link
Member

See #5 (review)

@ErikSchierboom
Copy link
Member

@glennj CI is failing

@glennj
Copy link
Author

glennj commented Nov 3, 2023

@ErikSchierboom and now CI not running?

@ErikSchierboom
Copy link
Member

@glennj I had merged master into this branch, but it looked like those commits were gone in this branch.

…ith a digit.

2. you have to tell tokei that the language allows nested comments
@glennj
Copy link
Author

glennj commented Nov 3, 2023

Phew, that was a journey!

@ErikSchierboom
Copy link
Member

You won though! Let me try this :)

@ErikSchierboom ErikSchierboom merged commit d7ec161 into exercism:master Nov 3, 2023
@glennj glennj deleted the 8th branch November 3, 2023 14:51
@ErikSchierboom
Copy link
Member

ErikSchierboom commented Nov 3, 2023

We're re-counting the existing 8th submissions' lines of code right now.

@ErikSchierboom
Copy link
Member

Processing done. For fun, I did a quick count. The following hash shows num_loc => num_submissions

{1=>134,
2=>78,
3=>252,
4=>30,
5=>36,
6=>24,
7=>20,
8=>16,
9=>13,
10=>19,
11=>13,
12=>25,
13=>16,
14=>7,
15=>13,
16=>6,
17=>8,
18=>14,
19=>10,
21=>10,
22=>2,
23=>10,
24=>2,
25=>6,
26=>2,
27=>4,
28=>4,
29=>2,
30=>5,
31=>7,
32=>5,
33=>1,
34=>3,
35=>2,
36=>2,
37=>2,
38=>5,
41=>2,
42=>2,
43=>1,
45=>1,
46=>2,
49=>1,
50=>4,
52=>2,
53=>1,
54=>1,
55=>2,
57=>1,
62=>1,
63=>4,
69=>3,
83=>1,
92=>2,
94=>3}

ErikSchierboom added a commit that referenced this pull request Nov 9, 2023
* Add LFE support

* Revert formatting changes to README.md

* Fix formatting again

* Update CI badge in README.md (#4)

* Add test workflow (#7)

* Add test workflow

* Don't use matrix

* Try inline cross

* Pin runner

* Directly download release via CLI

* Add caching

* Extract to bash file

* Last tweaks

* Add support for 8th (#1)

Add support for 8th

---------

Co-authored-by: Erik Schierboom <[email protected]>

* add wren support (#8)

* Trigger lines of code counter redeploy (#9)

* Add LFE support

* Revert formatting changes to README.md

* Fix formatting again

* Remove scheme submodule

* Add quotes

* Update lfe.lfe

* Increment comment count

* Decrement blank count

---------

Co-authored-by: Erik Schierboom <[email protected]>
Co-authored-by: Glenn Jackman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants