Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] (Issue 728) Fix/improve Lasagna introduction.md #729

Merged

Conversation

adamazing
Copy link
Contributor

What this fixes:

  • Issues/improvements raised in issue Documentation: introduction.md improvements / fixes for Lasagna #728:
    • Two sentences that seem to say the same thing (drawing the distinction between explicit type annotation and implicit typing by the compiled)
    • Spelling errors
    • Possible misuse of 'parse' for 'pass'?
    • Transposition of words (s/are functions/functions are/)

Related issue: #728

@meatball133
Copy link
Member

I am a bit unsure of using an example for writing comments. Since there are multiple occasions in other examples examples are used and I don't know if a specific example for comment is hence needed.

Changes should also be applied to the following files:

  • concept:basic:about.md
  • concept:basic:introduction.md

@adamazing adamazing force-pushed the 728-fix-improve-lasagna-introduction branch from a876572 to 233b515 Compare March 15, 2024 00:46
@adamazing adamazing force-pushed the 728-fix-improve-lasagna-introduction branch from 233b515 to 359e11c Compare March 15, 2024 02:27
@adamazing adamazing force-pushed the 728-fix-improve-lasagna-introduction branch from 359e11c to e29236e Compare March 15, 2024 02:35
@adamazing adamazing requested a review from meatball133 March 15, 2024 02:37
@meatball133 meatball133 linked an issue Mar 15, 2024 that may be closed by this pull request
@meatball133 meatball133 merged commit 808c099 into exercism:main Mar 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: introduction.md improvements / fixes for Lasagna
2 participants