-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix prerequisites of concept exercises #484
Conversation
Some concept exercises (like magician-in-training) depend on the "conditionals" concept, but this concept does not exist. This causes the concept exercises to remain locked even if someone completed all the conditionals-related exercises.
Also, using separate concepts for |
The `strings` concept does not exist, it's called `characters` instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, using separate concepts for if/guard/switch conditionals seems like overkill to me. In my opinion one single "conditionals" concept, where some exercises dive deeper into either if, guard or switch conditionals would be a cleaner way to do it, from a learner's perspective.
Yep, this is totally fine. Feel free to change this in a follow-up PR.
Any chance this can be merged? That allows me to continue on my Swift track 🙃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, forgot about this
No problem, thanks for merging! 👍 |
This fixes some prerequisites of concept exercises that point to concepts that do not exist (yet). Specifically, the following non-existing concepts were prerequisites for other exercises:
strings
(should probably becharacters
instead)conditionals
(covered byconditionals-if
,conditionals-guard
andconditionals-switch
)Because of these incorrect prerequisites some exercises remain locked without a way to unlock them.
Note: An alternative fix for
conditionals
could be to add theconditionals
concept to the appropriate exercises instead of changing the prerequisites of the others.