Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prerequisites of concept exercises #484

Merged
merged 2 commits into from
Oct 1, 2021

Conversation

sanderploegsma
Copy link
Contributor

@sanderploegsma sanderploegsma commented Sep 24, 2021

This fixes some prerequisites of concept exercises that point to concepts that do not exist (yet). Specifically, the following non-existing concepts were prerequisites for other exercises:

  • strings (should probably be characters instead)
  • conditionals (covered by conditionals-if, conditionals-guard and conditionals-switch)

Because of these incorrect prerequisites some exercises remain locked without a way to unlock them.

Note: An alternative fix for conditionals could be to add the conditionals concept to the appropriate exercises instead of changing the prerequisites of the others.

Some concept exercises (like magician-in-training) depend on the "conditionals" concept, but this concept does not exist. This causes the concept exercises to remain locked even if someone completed all the conditionals-related exercises.
@sanderploegsma
Copy link
Contributor Author

sanderploegsma commented Sep 24, 2021

Also, using separate concepts for if/guard/switch conditionals seems like overkill to me. In my opinion one single "conditionals" concept, where some exercises dive deeper into either if, guard or switch conditionals would be a cleaner way to do it, from a learner's perspective.

The `strings` concept does not exist, it's called `characters` instead.
@sanderploegsma sanderploegsma changed the title Fix prerequisites of concept exercises depending on "conditionals" Fix prerequisites of concept exercises Sep 27, 2021
@sanderploegsma sanderploegsma mentioned this pull request Sep 29, 2021
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, using separate concepts for if/guard/switch conditionals seems like overkill to me. In my opinion one single "conditionals" concept, where some exercises dive deeper into either if, guard or switch conditionals would be a cleaner way to do it, from a learner's perspective.

Yep, this is totally fine. Feel free to change this in a follow-up PR.

@sanderploegsma
Copy link
Contributor Author

Any chance this can be merged? That allows me to continue on my Swift track 🙃

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot about this

@ErikSchierboom ErikSchierboom merged commit 6048fa0 into exercism:main Oct 1, 2021
@sanderploegsma sanderploegsma deleted the patch-1 branch October 1, 2021 11:04
@sanderploegsma
Copy link
Contributor Author

No problem, thanks for merging! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants