Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace Cleanup #150

Closed
wants to merge 1 commit into from
Closed

Whitespace Cleanup #150

wants to merge 1 commit into from

Conversation

jonallured
Copy link
Contributor

I know, I know, whitespace - who cares? It was just really bothering me that there was so much inconsistency, so I did my best to resist frivolous changes and stuck to mostly running:

Editor > Structure > Re-Indent

With 4 spaces as my indent. It's about as close as we can get to gofmt and seemed reasonable. Most of the files I saw matched this format anyway, many just had a mistake here or there.

Then I just went through and removed some bonus newlines. Ahhh, much better!! 😎

I know, I know, whitespace - who cares? It was just really bothering me
that there was so much inconsistency, so I did my best to resist
frivolous changes and stuck to mostly running:

Editor > Structure > Re-Indent

With 4 spaces as my indent. It's about as close as we can get to `gofmt`
and seemed reasonable. Most of the files I saw matched this format
anyway, many just had a mistake here or there.

Then I just went through and removed some bonus newlines. Ahhh, much
better!! 😎
@masters3d
Copy link
Contributor

Oh I know! I wish we had a standard swift format tool like gofmt but we don't have that yet.
#10

I am not sure what the stand is for exercism as a project on whitespace only PRs but this being a swift language track I am going to close this for now until we have an official swift linter.

References:
swiftlang/swift#275
swiftlang/swift#963

@masters3d masters3d closed this Jun 5, 2016
@kytrinyx
Copy link
Member

kytrinyx commented Jun 5, 2016

I think that if we are internally inconsistent, we could probably choose some sort of rule-set just for the repo, and be consistent with that (in which case whitespace-only PRs would totally be a good thing). I think the question is--are we inconsistent? If so, what sort of consistency is important? If we make it consistent, is there some sort of mini-linting that we could do to make it easy to keep things consistent (and also something that we could run on CI)?

@masters3d
Copy link
Contributor

I would love a CI solution that makes a lint commit. . I have heard of something like that but I am not sure how to get it set up. I know travis can check lint rules but I don't know about actually making a "Lint" commit. https://www.bignerdranch.com/blog/continuous-linting/

@jonallured
Copy link
Contributor Author

Makes sense, I'll try to make progress on #10 instead. Thanks!! :D

@jonallured jonallured deleted the fix-whitespace branch June 5, 2016 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants