Add pangram exercise #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kytrinyx
previously requested changes
Oct 23, 2016
pangram/pangram.sml
Outdated
| @@ -0,0 +1,2 @@ | |||
| fun isPangram (sentence: string): bool = | |||
There was a problem hiding this comment.
Same thing here as in the difference of squares pull request—we don't have these failing stubs elsewhere, and I would favor consistency unless you get a discussion going and there's a consensus that this would be desirable in the SML track.
pangram/test_pangram.sml
Outdated
| ("7h3 qu1ck brown fox jumps ov3r 7h3 lazy dog", false), | ||
| ("\"Five quacking Zephyrs jolt my wax bed.\"", true) | ||
| (*"Victor jagt zwölf Boxkämpfer quer über den großen Sylter Deich.", true*) | ||
| (*"Широкая электрификация южных губерний даст мощный толчок подъёму сельского хозяйства.", false*) |
There was a problem hiding this comment.
Let's either add a comment clarifying why there are commented out test cases or delete them.
|
Do we care about the runtime for the example solution? It is currently |
snahor
dismissed
kytrinyx’s stale review
The review is no longer valid, we are using failing stubs and test data from problem-specifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.