Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binary: improve tests for invalid numbers #110

Closed
kytrinyx opened this issue Apr 7, 2016 · 1 comment
Closed

binary: improve tests for invalid numbers #110

kytrinyx opened this issue Apr 7, 2016 · 1 comment

Comments

@kytrinyx
Copy link
Member

kytrinyx commented Apr 7, 2016

We should have separate tests for:

  • alphabetic characters at the beginning of a valid binary number
  • alphabetic characters at the end of a valid binary number
  • alphabetic characters in the middle of an otherwise valid binary number
  • invalid digits (e.g. 2)

If the test suite for binary has test cases that cover these edge cases, this issue can safely be closed.

See exercism/problem-specifications#95
@ricemery
Copy link
Member

The Scala tests cover all these test cases other than

  • Invalid digits.

I will add a test case.

ricemery added a commit to ricemery/xscala that referenced this issue Apr 12, 2016
@ricemery
Add invalid digit test. Refs exercism#110
d67a4c3
ricemery added a commit that referenced this issue Apr 12, 2016
@ricemery
Merge pull request #114 from ricemery/binary-test-update
ec200b7 
Add invalid digit test. Refs #110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kytrinyx @ricemery