-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hints to gigasecond lib.rs #306
Conversation
The signature of the function is not at all obvious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, though I don't think we have any other example where we put a short description of the exercise in a comment. I don't mind, but let see what the others think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our current examples that have comments explaining the task have had the comments above the function:
- https://github.com/exercism/rust/blob/master/exercises/all-your-base/src/lib.rs
- https://github.com/exercism/rust/blob/master/exercises/variable-length-quantity/src/lib.rs
- https://github.com/exercism/rust/blob/master/exercises/react/src/lib.rs
Is not so important to me that I insist on the change now. Anyone want it to be above?
I lean to having the comment above, but it's not a blocker. |
I stand corrected :) |
One might also think that the comment, being written as an imperative (rather than third person), was a code comment saying what the code will do, rather than a documentation comment. Thus it could have been intentional to have it be that way. I'll move it up to match our existing ones and add unimplemented I suppose, then merge. Wouldn't want to spend too much time thinking about which of the two to use, otherwise the value of the time spent exceeds the value gained from either alternative. |
All right, very good, thank you.
reporting experiences of bafflement there will be helpful! whether they be personal experience or working with someone and observing that person's experience
I personally would. It would be useful to check at #269 to make sure people are on the same page. If it is true that figuring out how to infer the signature from reading the tests or error messages is a skill to learn (an argument against having stubs), perhaps just the first few exercise? |
The signature of the function is not at all obvious.
EDIT: It seems this is being discussed in #269, to be it's obvious we want the signatures, the exercises baffling to a begginer otherwise. I want to use exercism to teach rust at a workshop, I'll gladly add a bunch of stubs if the PRs will be accepted.