Pin problem-specifications to a specific commit #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous approach used a submodule to keep things somewhat stable. That worked well for the rust-tooling (exercise generator) which made use of the submodule. However, configlet continued to use its own cache. (see exercism/configlet#816) This could lead to problems where the configlet cache and the submodule are out of sync and don't agree. The new approach ditches the submodule and makes everything use the configlet cache. Some helper scripts are responsible to make sure the cache is checked out at the pinned commit and a configlet wrapper sets the `--offile` flag to prevent configlet from updating the cache.
ErikSchierboom
approved these changes
Aug 9, 2024
senekor
added a commit
that referenced
this pull request
Aug 13, 2024
With the configlet wrapper added in #1950, the `--offline` flag is now always set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach used a submodule to keep things somewhat stable.
That worked well for the rust-tooling (exercise generator) which made
use of the submodule. However, configlet continued to use its own cache.
(see exercism/configlet#816)
This could lead to problems where the configlet cache and the submodule
are out of sync and don't agree.
The new approach ditches the submodule and makes everything use the
configlet cache. Some helper scripts are responsible to make sure the
cache is checked out at the pinned commit and a configlet wrapper sets
the
--offileflag to prevent configlet from updating the cache.