Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bloated docker image #97

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Fix bloated docker image #97

merged 1 commit into from
Nov 23, 2023

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Nov 22, 2023

No description provided.

@senekor
Copy link
Contributor Author

senekor commented Nov 22, 2023

By coincidence, I inspected the size of the docker image when merging the prune-dependencies branch. It was 2.5 GB. Turns out local-registry/target was acciedentally copied into the final image. Removing that puts us back to around 890 MB.

I don't know when and why this regression was introduced. It seems that .dockerignore has slightly different sematics than .gitignore, because for the latter target/ also automatically matches subdirectories.

@senekor senekor marked this pull request as ready for review November 22, 2023 09:20
@senekor senekor requested a review from a team as a code owner November 22, 2023 09:20
ErikSchierboom
ErikSchierboom approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Would this also apply to the other Rust docker images?

@senekor
Copy link
Contributor Author

senekor commented Nov 23, 2023

I think they should be fine, their docker build is quite a bit simpler. I'll check the representer and the analyzer anyway in the next couple days.

@senekor senekor merged commit dd088a4 into main Nov 23, 2023
2 checks passed
@senekor senekor deleted the fix-bloated-docker-image branch November 23, 2023 08:37
@senekor
Copy link
Contributor Author

senekor commented Nov 23, 2023

@ErikSchierboom the analyzer and representer images are only 16 and 17 MB 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@senekor @ErikSchierboom