hello world tests via updated x-common data #550
Conversation
There was a problem hiding this comment.
Should the example implementation be updated to remove the Hello, Foo functionality?
Not sure if any of these are really that important, just things that I noticed 😄.
| class HelloWorldTest < Minitest::Test | ||
| def test_no_name | ||
| def test_Say_Hi! |
There was a problem hiding this comment.
Should this maybe be downcased to test_say_hi?
| 2 |
There was a problem hiding this comment.
Does the version need to be bumped since the old implementation is still valid?
There was a problem hiding this comment.
Clarification on why I believe it needs to be incremented is that old version would take an argument, this new version will not accept an argument.
There was a problem hiding this comment.
I like the version increment.
kotp
force-pushed
the
hello-world_Simplified
branch
from
2c3a6c3 to
72f5d93
Compare
|
nb: Generator still uses git commit sha for version, perhaps should use canonical data version instead. @Insti @tommyschaefer ? |
|
Generator should be using the sha1 from the canonical data repository already. |
Now I've caught up a bit more I see you mean the version property that is now present in the canonical-data.json files. I'll need to think about the implications of this. Will continue the discussion in: #485 |
Description
Uses the x-common data to simplify the hello world introductory exercise and tests.
Motivation and Context
re: exercism/problem-specifications#520