Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binary: improve tests for invalid numbers #275

Closed
kytrinyx opened this issue Apr 7, 2016 · 3 comments
Closed

binary: improve tests for invalid numbers #275

kytrinyx opened this issue Apr 7, 2016 · 3 comments
Labels
first-timers only good first patch

Comments

@kytrinyx
Copy link
Member

kytrinyx commented Apr 7, 2016

We should have separate tests for:

  • alphabetic characters at the beginning of a valid binary number
  • alphabetic characters at the end of a valid binary number
  • alphabetic characters in the middle of an otherwise valid binary number
  • invalid digits (e.g. 2)

If the test suite for binary has test cases that cover these edge cases, this issue can safely be closed.

See exercism/problem-specifications#95
@kotp
Copy link
Member

kotp commented Apr 7, 2016

I like the suggestion about common test data, but I will look into this more later today as well.

@kotp kotp assigned kotp and unassigned kotp Apr 7, 2016
@kotp
Copy link
Member

kotp commented Apr 13, 2016

@kytrinyx I think this is one that would be perfect for first patch or first timers only. I know that we are thinking about x-common tests for this, but that could be some time, in the meanwhile this could be put in place.

@casto101
Copy link
Contributor

I'm a first time open source contributor! I'd love to tackle this.

@casto101 casto101 mentioned this issue Apr 14, 2016
Merged
@kotp kotp closed this as completed in 260bb7c Apr 15, 2016
kotp added a commit that referenced this issue Apr 15, 2016
@kotp
Merge pull request #296 from casto101/add-binary-test-edgecases
fc8d435 
binary: Add invalid edge case tests. Closes #275
gchan pushed a commit to gchan/xruby that referenced this issue Oct 18, 2016
@Cohen-Carlisle
Merge pull request exercism#275 from tgecho/patch-2
cdfb4a2 
Remove track specific wording from triangle readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
first-timers only good first patch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kotp @kytrinyx @casto101