Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI to verify exercises against example implementation #65

Merged
merged 6 commits into from
Aug 17, 2022
Merged

Conversation

ErikSchierboom
Copy link
Member

@ErikSchierboom ErikSchierboom commented Aug 16, 2022

@loziniak The PR currently fails. This is due to the test runner's output not being conform the specification.
Here is some sample output of the test runner:

{"version":2,"status":"ignored","message":null,"tests":[{"name":"Convert an array to linked list, and then from linked list back to array","status":"pass","message":"✓","output":"","test_code":"solution = [3 6 1]"},{"name":"Convert from array, reverse the list, and covert to array","status":"ignored","message":"✓","output":null,"test_code":"solution = none"}]}

The problem is that the general and test status fields are set to ignored, which is not one of the three allowed values (pass/fail/error): https://exercism.org/docs/building/tooling/test-runners/interface
I assume this is because, well, the tests are ignored. The solution is for the test runner to un-ignore the tests before it runs them. Let me know if you have any questions.

Closes #48

This was referenced Aug 16, 2022
@loziniak
Copy link
Member

That's because of line:

test-init/limit %simple-linked-list.red 1

Which executes only first test, rest is ignored. What is the preferred behavior, should test-runner run all the tests by default?

@ErikSchierboom
Copy link
Member Author

What is the preferred behavior, should test-runner run all the tests by default?

Yes, that is correct!

loziniak added a commit to exercism/red-test-runner that referenced this pull request Aug 16, 2022
Merge pull request #48 from exercism/ci

Let's try to merge this into *main* again and then see how does it work for exercism/red#65 .
@loziniak loziniak merged commit 0614a6a into main Aug 17, 2022
@SleeplessByte SleeplessByte deleted the add-ci branch August 18, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continuous Integration
2 participants