Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isogram #174

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Add isogram #174

merged 1 commit into from
Jun 10, 2024

Conversation

BNAndras
Copy link
Member

@BNAndras BNAndras commented Jun 9, 2024

For #48in24

@BNAndras BNAndras added x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation labels Jun 9, 2024
kotp
kotp approved these changes Jun 9, 2024
View reviewed changes
Copy link
Member

@kotp kotp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approved in case the comment is purposeful.

exercises/practice/isogram/isogram-test.red
#include %testlib.red

test-init/limit %isogram.red 1
; test-init/limit %.meta/example.red 1 ; test example solution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment meant to still be here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's part of the template. It must be for testing the example locally when implementing an exercise since the test CI overwrites isogram.red with example.red without touching that line.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's part of the template. It must be for testing the example locally when implementing an exercise since the test CI overwrites isogram.red with example.red without touching that line.

Thanks.

Approved, but I do not have write-bit to bring it in.

@BNAndras BNAndras merged commit caa7b39 into exercism:main Jun 10, 2024
3 checks passed
@BNAndras BNAndras deleted the add-isogram branch June 10, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotp kotp kotp approved these changes

Assignees
No one assigned
Labels
x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BNAndras @kotp