-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add crypto-square exercise #75
Conversation
Implement tests and example solution Generate README Update config
Following the advice of this discussion in exercism/problem-specifications, I opted to include intermediate methods in the tests here. Having said that, I think there might be quite a wide variety of ways to move from the input text to the ciphertext and these intermediate methods could get in the way of an elegant implementation rather than aiding in the learning process. My example solution here cleanses the input string and then maps the characters out into a matrix which makes the 'encoding' process easy. This makes the intermediate methods |
Sorry! I overlooked this the last 2 months, and won't have spare time in the next few weeks either. |
Ok no worries. I don't think the approach of the example solution matters too much, but I'd like a 2nd opinion on whether these intermediate methods should be included in the starting snippet (and more importantly whether they should be tested), so will just keep this PR open for now until you can revisit it later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got all but the last test to go green. It's tricky, but fine to include.
Thanks! So you think it's fine to include the tests for the intermediate methods? |
I think those did prevent me from finding a solution to the last test. I had duplicated Because I think it's better to have a really tricky puzzle in the track, than not, I'm OK with merging this. Please squash, because the two merges & conflict resolutions were this messy, because I tried the web-editor for a change, not a JSON-validating IDE :-/ |
Hi @jonmcalder! Do you have any doubts about merging & squashing this? |
Thanks @katrinleinweber! I must have missed/overlooked this somehow - I'm ok with it since you are. I'm sure we (or others) can refine it at a later stage if need be :-) |
Implement tests and example solution
Generate README
Update config