-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python Track Syllabus]: Track Re-Ordering #3057
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Wow! That's a lotta work! It's kind of late for me now. I'd like to review this tomorrow when my mind is fresh, if that's okay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested changes center on difficulty levels, prerequisites, and what is being practiced for exercises with which I'm familiar from having solved and mentored them. However, they are somewhat subjective, so if none of them are accepted I won't take offense.
"slug": "triangle", | ||
"name": "Triangle", | ||
"uuid": "f0bc144f-3226-4e53-93ee-e60316b29e31", | ||
"practices": ["bools"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great exercise to introduce a decorator for validating triangle validity, but if it only can practice one concept, then booleans would be it. Although sets could also be a practiced concept here, as many solutions use the len of a set of the three sides. Not sure why the restriction to practicing only one concept.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "restriction" is around how unlocking logic works. If I have this exercise practice "bools", it will show up in the tree under "bools", and be unlocked by it. Most students will then take on the exercise once they finish the "bools" concept exercise. By the time they get to doing sets
, this exercise will have already been "practiced", and so be redundant for them...and vice-versa. If I have it practice sets
, it will not be locked until the prerequisite is satisfied. But that closes off the exercise from students who've only completed "bools".
....But maybe this is an an opportunity to create a similar problem or extended problem, purpose-built for a set-wise solution? Analogous to "Resistor Color Duo" - only in this case, comparing triangles?? Same for decorators
-- doing maybe a transform decorator that changes a triangle from one category to another??......
I don't know. But the upshot (at least for the early exercises) is that we need to pick a "main" concept that an exercise practices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to leave this "unresolved", just to have the convo open. I think for now I will leave this as-is, with the thought we'd make extended or variant exercises to triangle
.
Alrighty. I've pushed the suggested changes. I think we can put a pin in this for now. Maybe revisit it in a bit. 😄 Thank you for your (very) thoughtful review! 🌟 |
@bobahop - do we merge these changes thus far, or would you like to look at / discuss further? I am happy either way. 😄 |
Sorry it took me so long to notice this. I have nothing I feel strongly about to change, so I've approved it. This is truly a massive amount of dedication and work! |
eeek. Pushing the big, green button. Let's hope this doesn't make things explode. 😬 If it is a total and complete disaster, I suppose we can always revert and try again. 😉 |
Nah. I am 🐔 ...I will wait to merge until EU morning or tomm US time. |
Yeah, probably best to do it when it's earlier and the mind is fresher to deal with possible unintended consequences. |
Marked as massive, due to the amount of re-reviewing, visualization, and re-ordering.
These are changes to address issue #2714 & #3023, and include:
Syllabus Tree Before (aka "current" tree on website)
Syllabus Tree After (aka "new" tree)
Table Representation of New Syllabus (Beta Exercises Only)