Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Names of Test Classes to be ExerciseNameTest #2603

Merged
merged 1 commit into from
Sep 26, 2021

Conversation

BethanyG
Copy link
Member

This way, the results will read ExerciseName > test_name without having to resort to a more complicated regex and logic in the Test Runner.

The following exercise test files were changed:

  • black_jack_test.py
  • lists_test.py
  • list_methods_test.py
  • exchange_test.py
  • arcade_game_test.py
  • dicts_test.py
  • string_methods_test.py
  • strings_test.py
  • enums_test.py
  • conditionals_test.py
  • string_formatting_test.py
  • none_test.py
  • tuples_test.py

lists_test.py was also edited to omit tests for example code.

@BethanyG BethanyG added the x:size/large Large amount of work label Sep 26, 2021
@BethanyG BethanyG requested a review from a team September 26, 2021 19:45
@BethanyG
Copy link
Member Author

I tried, but couldn't get the results.json file for making the grade to delete. Much obliged if a reviewer can do it. Otherwise, i will have to submit a follow-on PR.

Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the making-the-grade json file is deleted.

Approving

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/large Large amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants