Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rectangles: sync expected test results and input data with problem-specifications. #1819

Merged
merged 4 commits into from
Jun 11, 2019

Conversation

BethanyG
Copy link
Member

@BethanyG BethanyG commented Jun 2, 2019

Part of #1762

  • Changed function name to rectangles in tests, example.py, and exercise stub to conform with canonical-data.json
  • Changed function argument name to strings in example.py and exercise stub to conform with canonical-data.json
  • Changed most single letter variable names to words in example.py for clarity.
  • Changed comparisons to 0 to if not checks in example.py for clartiy.
  • Replaced nested loop in search_corners function to a comprehension in example.py

@BethanyG BethanyG requested a review from a team as a code owner June 2, 2019 23:25
@cmccandless cmccandless merged commit 0a52d8e into exercism:master Jun 11, 2019
@BethanyG BethanyG deleted the rectangles-changes branch January 29, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants