-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Palindrome products: sync expected test results and input data with problem-specifications. #1814
Palindrome products: sync expected test results and input data with problem-specifications. #1814
Conversation
Pull in New Changes from Main Repo
Merge in Changes from Main Repo
…roblem-specifications.
…mple.py, due to python2.7 failures.
@@ -1,53 +1,51 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def largest_palindrome(max_factor, min_factor): | ||
return get_extreme_palindrome_with_factors(max_factor, min_factor, | ||
"largest") | ||
def largest(min, max): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
min
and max
are reserved.
def largest(min, max): | |
def largest(min_factor, max_factor): |
@@ -1,10 +1,10 @@ | |||
""" | |||
Notes regarding the implementation of smallest_palindrome and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notes regarding the implementation of smallest_palindrome and | |
Notes regarding the implementation of smallest and |
…to remove reserved words and fix typoes.
Since I needed to alter the tests as well, decided to push additional changes.
|
Merged; thanks for working on this! |
Part of #1762
example.py
, and exercise stub to conform withcanonical-data.json
.example.py
, and exercise stub to conform withcanonical-data.json
.canoncial-data.json
.example.py
to better clarify code and remove single letter variable names.Removedfrom __future__ import division
fromexample.py