Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List ops: sync expected test results and input data with problem-specifications. #1801

Merged
merged 6 commits into from
May 31, 2019

Conversation

BethanyG
Copy link
Member

Part of #1762

  • Changed function names to map and filter in tests, example.py, and exercise stub to conform with canonical-data.json.
  • Changed changed function argument names to list, inital, and function in example.py and exercise stub to better conform to canonical-data.json.
  • Changed references to single, two-letter, and abbreviated variable names in example.py to whole words for clarity.

@BethanyG BethanyG requested a review from a team as a code owner May 29, 2019 20:32
Copy link
Contributor

@cmccandless cmccandless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments that need name changes.

Normally, I prefer not to shadow builtin names, but since the core purpose of this exercise is to reimplement the wheel, I am fine with doing so here.

exercises/list-ops/list_ops_test.py Outdated Show resolved Hide resolved
exercises/list-ops/list_ops_test.py Outdated Show resolved Hide resolved
BethanyG and others added 2 commits May 30, 2019 07:59
@BethanyG
Copy link
Member Author

BethanyG commented May 30, 2019

Yeah. I do have to admit that this exercise and its function names made my heart quail, a bit. But agreed: the point here is to re-invent the wheel, and hopefully code like this wouldn't see the light of day outside this exercise.

@cmccandless cmccandless merged commit 6fa8185 into exercism:master May 31, 2019
@cmccandless
Copy link
Contributor

Merged; thanks for working on this!

Grociu added a commit to Grociu/fork-of-exercism-python that referenced this pull request May 31, 2019
* minesweeper: sync expected test results and input data with problem-specifications.

* minesweeper: small additional edit to example.py to replace *r* with word *row* instead.

* Meetup : sync expected test results and input data with problem-specifications. (exercism#1803)

* minesweeper: revert changes to testfile that put input and expected results on single lines.

* word-count: sync with canonical data (exercism#1805)

* List ops: sync expected test results and input data with problem-specifications. (exercism#1801)

Co-Authored-By: Corey McCandless <[email protected]>
@BethanyG BethanyG deleted the list-ops-changes branch January 29, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants