Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Knapsack : sync expected test results and input data with problem-specifications. #1799

Merged
merged 3 commits into from
May 30, 2019
Merged

Knapsack : sync expected test results and input data with problem-specifications. #1799

merged 3 commits into from
May 30, 2019

Conversation

BethanyG
Copy link
Member

Part of #1762

  • Changed function name to maximum_value in tests, example.py and exercise stub to conform with canonical-data.json.
  • Changed function argument names to maximum_wight and items in example.py and exercise stub to conform with canonical-data.json.
  • Cleaned up indentation and formatting in tests and example.py to conform with flake 8
  • Changed single letter variable names to words in example.py

@BethanyG BethanyG requested a review from a team as a code owner May 29, 2019 18:06
@cmccandless cmccandless merged commit 876557a into exercism:master May 30, 2019
@cmccandless
Copy link
Contributor

Merged; thanks for working on this!

@BethanyG BethanyG deleted the knapsack-changes branch January 29, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmccandless cmccandless cmccandless approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BethanyG @cmccandless