Saddle-point: sync expected test results with problem-specifications #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merging in changes in order to run configlet
merge in most recent to prep for test editing.
…s and update example solution.
|
Part of #1762. |
cmccandless
suggested changes
May 22, 2019
There was a problem hiding this comment.
@BethanyG thanks for the PR! You have a few flake8 violations that need to be fixed:
5.45s$ flake8
./exercises/saddle-points/example.py:8:80: E501 line too long (89 > 79 characters)
./exercises/saddle-points/example.py:9:80: E501 line too long (87 > 79 characters)
./exercises/saddle-points/example.py:11:26: W292 no newline at end of file
./exercises/saddle-points/saddle_points_test.py:33:80: E501 line too long (94 > 79 characters)
./exercises/saddle-points/saddle_points_test.py:38:80: E501 line too long (94 > 79 characters)
./exercises/saddle-points/saddle_points_test.py:48:80: E501 line too long (99 > 79 characters)
./exercises/saddle-points/saddle_points_test.py:52:80: E501 line too long (99 > 79 characters)
./exercises/saddle-points/saddle_points_test.py:56:80: E501 line too long (99 > 79 characters)
The command "flake8" failed and exited with 1 during .
…s and update example solution.
|
Gah. You caught me. I've got guide set up now...and pycharm configured for Flake8. New push to correct - see b4a4334. |
cmccandless
approved these changes
May 23, 2019
|
Merged; thanks for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the tests to expect a list of
dict()objects (as specified in the canonical data), rater than a list of tuples. Changedexample.pycode to return a list ofdict()objects as well.