Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protein-translation: Add canonical data. #997

Merged
merged 9 commits into from
Nov 10, 2017
Merged

protein-translation: Add canonical data. #997

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
aed9084
Add protein translation canonical data as per #577.
sjwarner Nov 8, 2017
4c5b8e8
Update properties to reflect different return types.
sjwarner Nov 8, 2017
34c34a1
Update to test only one property, and fix formatting.
sjwarner Nov 8, 2017
be571bd
Update test description for clarity.
sjwarner Nov 8, 2017
135bcbe
Reduced length of test descriptions.
sjwarner Nov 8, 2017
a3e63c7
Update tests including 'STOP' codons for consistency.
sjwarner Nov 8, 2017
91095fa
Update 'STOP' test description
sjwarner Nov 8, 2017
a0be642
Update 'STOP' codon tests to expect an empty list.
sjwarner Nov 8, 2017
630c53d
Rename 'property', add a larger range of STOP codon tests, rearrange …
sjwarner Nov 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions exercises/protein-translation/canonical-data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,13 @@
"expected": ["Methionine","Phenylalanine","Tryptophan"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type returned by translate should be consistent; until this line, the output of translate has been a string, but now a list is expected. The python test cases use two different properties of_codon and of_rna for these; something similar would be appropriate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah of course - my mistake! I'll correct that 🙂

Copy link
Member

@rpottsoh rpottsoh Nov 8, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a lot like what has been discussed recently at #983. "translate_codon" seems to be an intermediate test of what the description is really asking for. The "translate_codon" tests may not belong. @petertseng, @Insti thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpottsoh I believe @ErikSchierboom beat you to it. See his comments.

},
{
"description": "Translation stops if STOP codon present 1",
"description": "Translation stops if STOP codon present in short string",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps Translation stops if STOP codon at end of sequence vs below Translation stops if STOP codon in middle of sequence?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or
Translation stops when STOP codon encountered

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to distinguish between this case and the next... perhaps Translation stops when STOP codon encountered at end of sequence vs Translation stops when STOP codon encountered in middle of sequence?

"property": "translate",
"strand": "AUGUUUUAA",
"expected": ["Methionine","Phenylalanine"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STOP is included in the above test cases where it is the only codon; either the above cases should expected empty lists as a result or STOP should be included in the results here.

},
{
"description": "Translation stops if codon present 2",
"description": "Translation stops if codon present in longer string",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per my above comment, perhaps a change in wording?

"property": "translate",
"strand": "UGGUGUUAUUAAUGGUUU",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put some thought put into which sequences are easiest for humans to read and distinguish.

"expected": ["Tryptophan","Cysteine","Tyrosine"]
Expand Down