Moved documentation on pull request guidelines #816
Conversation
CONTRIBUTING.md
Outdated
| @@ -586,33 +586,6 @@ or that are not particularly interesting. | |||
| Here are a few bits and pieces that are referenced from some of the | |||
| scenarios in this guide. | |||
|
|
|||
| ### Pull Request Guidelines | |||
There was a problem hiding this comment.
I think it is still important to reference the pull request guidelines in this document.
Linking is probably ok.
There was a problem hiding this comment.
I was thinking about that before sending the pull request. I agree with you. Would you like me to add it back in? Ideally it should contain a link to the PR guidelines once they're up.
|
Added heading back in and linked it to the doc in the docs repo |
Insti
changed the title
CONTRIBUTING.md
Outdated
| checking in every day. If you don't get a response within a couple of days, | ||
| feel free to ping us in the [support | ||
| chat](https://gitter.im/exercism/support). | ||
| See [here](https://github.com/exercism/docs/blob/master/contributing-to-language-tracks/pull-request-guidelines.md). This section has been moved to [docs](https://github.com/exercism/docs) repository. |
There was a problem hiding this comment.
Maybe "See here" could be replace with something like "See this document"? That sounds a bit better IMHO.
There was a problem hiding this comment.
Or even "See the pull request guidelines in the docs repository."
There was a problem hiding this comment.
Sounds good! I was having a hard time deciding what to put there. I'll change it and re-submit.
Moved to docs repository, check issue [#24] * Added link to newly moved pull request guidelines in docs repo
|
Should be good to go @ErikSchierboom! @kytrinyx I used your suggestion. Hopefully that works :-) |
|
This is great @aosdab, thank you! 🌷 |
Referencing issue #24 in docs repository.
I've deleted the PR guidelines portion from CONTRIBUTING.md as they are planned to be moved to the docs repo.