Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saddle-points: add canonical data #756

Merged
merged 1 commit into from
May 1, 2017
Merged

saddle-points: add canonical data #756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 87 additions & 0 deletions exercises/saddle-points/canonical-data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
{
"exercise": "saddle-points",
"version": "1.0.0",
"comments": [
"Matrix rows and columns are 0-indexed."
],
"cases": [
{
"description": "Can identify single saddle point",
"comments": [
"This is the README example."
],
"property": "saddlePoints",
"input": [
[9, 8, 7],
[5, 3, 2],
[6, 6, 7]
],
"expected": [
{
"row": 1,
"column": 0
}
]
},
{
"description": "Can identify that empty matrix has no saddle points",
"property": "saddlePoints",
"input": [
[]
],
"expected": []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be null instead of an empty array? The README indicates it does:

if the input is valid but there is no result for the input, the value at "expected" should be null.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my interpretation, the empty result is a result, therefore it is not no result. [] makes more sense than null here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, understood

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot, my bad. On reflection, it would seem that this is a case where it makes sense to update the description; I'll push a commit with that change this weekend :o)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ErikSchierboom forgive me, but I don't see where the line you quoted exists. The description for this exercise reads as follows:

A matrix may have zero or more saddle points.

Your code should be able to provide the (possibly empty) list of all the
saddle points for any given matrix.

Can you please point me to the source of the line you quoted? Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stkent It's in this repository's README. However, I think the empty list might after all be better in this case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, now I see, thanks! And yes, I think we now have three votes for an empty results list rather than an explicit null result :).

},
{
"description": "Can identify lack of saddle points when there are none",
"property": "saddlePoints",
"input": [
[1, 2, 3],
[3, 1, 2],
[2, 3, 1]
],
"expected": []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

},
{
"description": "Can identify multiple saddle points",
"property": "saddlePoints",
"input": [
[4, 5, 4],
[3, 5, 5],
[1, 5, 4]
],
"expected": [
{
"row": 0,
"column": 1
},
{
"row": 1,
"column": 1
},
{
"row": 2,
"column": 1
}
]
},
{
"description": "Can identify saddle point in bottom right corner",
"comments": [
"This is a permutation of the README matrix designed to test",
"off-by-one errors."
],
"property": "saddlePoints",
"input": [
[8, 7, 9],
[6, 7, 6],
[3, 2, 5]
],
"expected": [
{
"row": 2,
"column": 2
}
]
}
]
}