Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Extensions to RobotName #748

Closed
wants to merge 2 commits into from
Closed

Add Extensions to RobotName #748

wants to merge 2 commits into from

Conversation

masters3d
Copy link
Contributor

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should choose here: either define the duplicate avoidance clause as part of the exercise (as it is now), or as an extension. This kinda does both.

@masters3d
Copy link
Contributor Author

What do u think?

@Insti
Copy link
Contributor

Insti commented Apr 24, 2017

The unique robot name part was what made this problem interesting.
I would prefer it remained as a main part of the exercise.

@masters3d
Copy link
Contributor Author

Define unique? Have you gotten a chance to read the linked issue?

@Insti
Copy link
Contributor

Insti commented Apr 24, 2017

Define unique?

From the description:

Your solution should not allow the use of the same name twice

I have read the linked issue, do you need me to post my objection there as well?

@masters3d
Copy link
Contributor Author

That part it still part of the description. I am afraid that most of the tracks have chosen only to test about 10k permutations which is different that's the 600k permutations needed for a truly unique test.

@Insti
Copy link
Contributor

Insti commented Apr 24, 2017

most of the tracks have chosen only to test about 10k permutations which is different that's the 600k permutations needed for a truly unique test.

That's a deficiency of the tracks rather than an issue with the problem.
I believe the problem is good and it is the tests that need updating.

@masters3d
Copy link
Contributor Author

Not when that kind of test was specified like this

"In some exercism language tracks there are tests to ensure that the same name is never used twice."

That makes it sound optional. That is not the core concept of the exercise from the description.

@Insti Insti mentioned this pull request May 6, 2017
@masters3d masters3d closed this May 10, 2017
@masters3d masters3d deleted the masters3d-robotname branch May 10, 2017 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants