Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phone-number: Clears up contradiction re: why 11 digits is invalid #724

Merged
merged 1 commit into from
Mar 14, 2017

Conversation

rpottsoh
Copy link
Member

There are two tests concerning 11 digit numbers. One test says they are valid when the digits start with one. The other test states that 11 digits is invalid, but doesn't state why. The two tests seem to be contradicting each other.

@rpottsoh
Copy link
Member Author

I have to add, @kotp pointed this out to me as I was updating this exercise in the Delphi track.

There are two tests concerning 11 digit numbers.  One test says they are valid when the digits start with one.  The other test states that 11 digits is invalid, but doesn't state why.  The two tests seem to be contradicting each other.
Copy link
Contributor

@rbasso rbasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great!

The only thing that I would change is to bump the version number to 1.0.2, according to what was discussed in #673.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants