Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anagram: Rename duplicated test case description #671

Merged
merged 2 commits into from
Mar 10, 2017
Merged

Conversation

behrtam
Copy link
Contributor

@behrtam behrtam commented Mar 9, 2017

There are some tracks that generate their test suits and use the description field as name for the test function/method.
If this would get merged. Do we change the version to 1.1.0 or 1.0.1?

Note: Don't know if the new names are so great but I couldn't find different ones.

There are some tracks that generate their test suits and use the description field as name for the test function/method.
@rbasso
Copy link
Contributor

rbasso commented Mar 9, 2017

If this would get merged. Do we change the version to 1.1.0 or 1.0.1?

Great question @behrtam!

I guess it is time for us to discuss how to do semantic versioning of the canonical-data.json files.

@rbasso
Copy link
Contributor

rbasso commented Mar 9, 2017

Hold this for a while! I'm opening an issue to discuss that! #673

Copy link
Contributor

@rbasso rbasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to what we are discussing in #673, this change is backward-compatible and doesn't change the meaning of the test suite, so it should bump just the PATCH version: "1.0.1".

@rbasso rbasso merged commit 196fc1a into master Mar 10, 2017
@rbasso rbasso deleted the anagram-descriptions branch March 10, 2017 13:13
petertseng added a commit to petertseng/exercism-ceylon that referenced this pull request Apr 8, 2017
petertseng added a commit to exercism/haskell that referenced this pull request May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants