change: Added a positive case without 1 unit coin available #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpottsoh
changed the title
rpottsoh
reviewed
Mar 2, 2017
exercises/change/canonical-data.json
Outdated
| @@ -37,6 +37,12 @@ | |||
| "expected": [2, 2, 5, 20, 20, 50, 100, 100, 100, 100, 100, 100, 100, 100, 100] | |||
| }, | |||
| { | |||
| "description": "posible change without one coins available", | |||
There was a problem hiding this comment.
@weapp just a small grammatical nit pick, coins should be singular instead of plural. I like the added twist of not having a penny available. Thanks
There was a problem hiding this comment.
"coins of value one"?
"unit coins"?
All the current positive test cases include 1 unit coin in available coins and it's could be confusing. This commit proposes a new test case that is positive but not includes 1 unit coin in the input.
petertseng
approved these changes
Mar 3, 2017
ErikSchierboom
approved these changes
Mar 3, 2017
|
Thanks a lot @weapp! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the current positive test cases include 1 unit coin in available coins and it's could be confusing.
This commit proposes a new test case that is positive but not includes 1 unit coin in the input.