Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hello-world: clarify "says" #614

Merged
merged 1 commit into from
Feb 28, 2017
Merged

Conversation

kevinlitchfield
Copy link
Contributor

I think it could be worthwhile to clarify what "says" means in the exercise description. Often, "Hello, World!" programs print Hello, World! to the screen, but the Exercism exercises I've seen instead ask for a function that returns the string Hello, World!.

Because "says" could sound like it's figuratively referring to printing to the screen, and because a learner familiar with "Hello, World!" programs might expect to write a program that prints Hello, World! to the screen, I think "returns the string" might be clearer here.

Thoughts?

@kevinlitchfield kevinlitchfield changed the title Clarify "says" hello-world: clarify "says" Feb 27, 2017
@stkent
Copy link
Contributor

stkent commented Feb 27, 2017

+1 this. I think there are other exercises that could also benefit from the same adjustment (diamond springs to mind; I think that explicitly uses "prints", but most (all?) implementations return a list of strings).

Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Yeah, we should have paid attention to exercism/exercism#2746 when doing #544.

Just as you edited the PR title to include hello-world, going to amend the commit message to also do so.

@petertseng petertseng merged commit b25a8e1 into exercism:master Feb 28, 2017
emcoding pushed a commit that referenced this pull request Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants