Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hello-world: Change to always expect "Hello, World!" #544

Merged
merged 1 commit into from
Feb 20, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 9 additions & 21 deletions exercises/hello-world/canonical-data.json
Original file line number Diff line number Diff line change
@@ -1,23 +1,11 @@
{
"#": [
"Language implementations vary on the issue of missing input variables.",
"In this set of test cases, the input variable is left out of the definition,",
"and the generator would need to handle the language implementation."
],
"cases": [
{
"description": "no name",
"expected": "Hello, World!"
},
{
"description": "sample name",
"name": "Alice",
"expected": "Hello, Alice!"
},
{
"description": "other sample name",
"name": "Bob",
"expected": "Hello, Bob!"
}
]
"exercise":"hello-world",
"version":"0.1.0",
"cases":[
{
"description":"Say Hi!",
"property":"hello",
"expected":"Hello, World!"
}
]
}
49 changes: 7 additions & 42 deletions exercises/hello-world/description.md
Original file line number Diff line number Diff line change
@@ -1,46 +1,11 @@
["Hello, World!"](http://en.wikipedia.org/wiki/%22Hello,_world!%22_program) is
the traditional first program for beginning programming in a new language.
the traditional first program for beginning programming in a new language
or environment.

**Note:** You can skip this exercise by running:
The objectives are simple:

exercism skip $TRACK_ID hello-world
- Write a function that says "Hello, World!".
- Run the test suite and make sure that it succeeds.
- Submit your solution and check it at the website.

## Specification

Write a `Hello World!` function that can greet someone given their name. The
function should return the appropriate greeting.

For an input of "Alice", the response should be "Hello, Alice!".

If a name is not given, the response should be "Hello, World!"

## Test-Driven Development

As programmers mature, they eventually want to test their code.

Here at Exercism we simulate [Test-Driven
Development](http://en.wikipedia.org/wiki/Test-driven_development) (TDD), where
you write your tests before writing any functionality. The simulation comes in
the form of a pre-written test suite, which will signal that you have solved
the problem.

It will also provide you with a safety net to explore other solutions without
breaking the functionality.

### A typical TDD workflow on Exercism:

1. Run the test file and pick one test that's failing.
2. Write some code to fix the test you picked.
3. Re-run the tests to confirm the test is now passing.
4. Repeat from step 1.
5. Submit your solution (`exercism submit /path/to/file`)

## Instructions

Submissions are encouraged to be general, within reason. Having said that, it's
also important not to over-engineer a solution.

It's important to remember that the goal is to make code as expressive and
readable as we can. However, solutions to the hello-world exercise will not be
reviewed by a person, but by rikki- the robot, who will offer an encouraging
word.
If everything goes well, you will be ready to fetch your first real exercise.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. One note (probably to myself): while the instructions we lose in this Pull seem appropriate to remove here, they might be useful somewhere else. If we do end up choosing a intro-to-tdd exercise, this might be a good source for that description.md.

2 changes: 1 addition & 1 deletion exercises/hello-world/metadata.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
---
blurb: 'Greet the user by name, or by saying "Hello, World!" if no name is given.'
blurb: 'The classical introductory exercise. Just say "Hello, World!"'
source: "This is an exercise to introduce users to using Exercism"
source_url: "http://en.wikipedia.org/wiki/%22Hello,_world!%22_program"