change: Add case for target > coins, but still can't make #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current error cases ask us to ensure that two types of targets are invalid: * targets smaller than the smallest coin * negative targets These are both reasonable. I would react with chagrin if this led student solutions to assume that these are the only two cases in which one could fail to meet the target i.e. they assume that any target > the smallest coin is valid. This commit proposes adding a case that disproves that - the target is larger than even the largest coin, but you will not be able to get a combination that reaches the target.
|
Makes total sense to me; Java track is poised to add this so I'll hold that exercise until this is 👍'd and merged! |
|
LGTM! |
emcoding
pushed a commit
that referenced
this pull request
Nov 19, 2018
* bin/generate: Default display success message. The old behavior was: ``` $ bin/generate isogram $ ``` Which is not particularly friendly or helpful. Did it even do anything? The new default behavior is to report success to stdout: ``` $ bin/generate isogram Generated isogram tests version 3 $ ``` The original behavior can be replicated by redirecting stdout to /dev/null ``` $ bin/generate isogram > /dev/null $ ``` The `-v` option still provides additional information. ``` $ bin/generate -v isogram Incremented tests version to 4 Updated version in example solution to 4 Generated isogram tests version 4 ``` * Send all output via the logger. Use composition rather than inheritance for the Logging Repository decorator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current error cases ask us to ensure that two types of targets are
invalid:
These are both reasonable.
I would react with chagrin if this led student solutions to assume that
these are the only two cases in which one could fail to meet the target
i.e. they assume that any target > the smallest coin is valid.
This commit proposes adding a case that disproves that - the target is
larger than even the largest coin, but you will not be able to get a
combination that reaches the target.