Removes "write a program" from descriptions to address #321 #528
Conversation
|
I like it. It is all the same thing though, so could be one commit. |
|
That PR and the suggestion for 3 different commits was for a different reason. The change here is one problem, and does not have the potential to effect like the other could. |
|
Yeah I'd have to think about that one. I don't think I'd ever revert part of this PR but not the others, but I certainly won't complain about them being separate. could you amend some commit messages? cryto -> crypto, kindergarten-garten -> kindergarten-garden, otcal -> octal, and serach -> search. |
|
Thanks for the review @petertseng. I reviewed the changes before submitting but not the commit messages. I'll update them this evening. |
| output the notes in the given scale, starting with the tonic and | ||
| following the specified interval pattern. | ||
| Generate musical scales accepting a tonic, or starting note, and | ||
| a set of intervals. It should be able to output the notes in the |
There was a problem hiding this comment.
Previously, "it" referred to the program, and now I'm not sure "it" makes sense any longer. Maybe it will make sense by simply removing the words "It should"?
There was a problem hiding this comment.
I decided to reword the whole sentence to the "Given a xxx" syntax.
exercises/anagram/metadata.yml
Outdated
| @@ -1,4 +1,4 @@ | |||
| --- | |||
| blurb: "Write a program that, given a word and a list of possible anagrams, selects the correct sublist." | |||
| blurb: "Given a word and a list of possible anagrams, selects the correct sublist." | |||
exercises/binary-search/metadata.yml
Outdated
| @@ -1,4 +1,4 @@ | |||
| --- | |||
| blurb: "Write a program that implements a binary search algorithm." | |||
| blurb: "Implements a binary search algorithm." | |||
There was a problem hiding this comment.
Probably "Implement" here, so that the verb is consistent with other blurbs.
exercises/twelve-days/metadata.yml
Outdated
| @@ -1,4 +1,4 @@ | |||
| --- | |||
| blurb: "Write a program that outputs the lyrics to 'The Twelve Days of Christmas'" | |||
| blurb: "Outputs the lyrics to 'The Twelve Days of Christmas'" | |||
There was a problem hiding this comment.
Probably "Output" here, to match verbs.
|
@petertseng is right, the same concern. I would not expect a portion of these to want to be reverted. It isn't a big deal about the individual commits, except a lot of short-interval work. And as noted, lots of opportunity for small errors in typing. |
robkeim
force-pushed
the
write-a-program
branch
from
8aa5b97 to
e692580
Compare
|
@petertseng I went ahead and updated the PR with your comments, thanks again for the review @kotp I left the individual commits for now, but I could squash them with the merge, I don't have a preference. |
|
Either way is good for me. With a squash, the commit will read really well, itemized. |
|
Somehow, we lost the also, can we get grade-school too? It says "Write a small archiving program" |
|
Thanks @petertseng for all of the valuable feedback! It looks like the Travis CI builds are backed up, so I'll merge this once the build completes. |
#321