Update largest_series_product tests #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move the simplest case to the first test Before this change the first test required students to implement the 'windowing' logic. By moving the test where span = input length to the first test, the student can get to green faster and then implement the windowing logic later. - Remove duplicate tests The removed tests didn't introduce any new logic or edge cases, so I'm removing them. I think there's a case to be made for removing more of the tests because one a student has implemented logic for handling a span of 2 they probably don't need to do any work to handle larger spans.
emcoding
pushed a commit
that referenced
this pull request
Nov 19, 2018
[isogram] Eliminate trailing whitespace in test file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change the first test required students to implement the
'windowing' logic. By moving the test where span = input length to the
first test, the student can get to green faster and then implement the
windowing logic later.
The removed tests didn't introduce any new logic or edge cases, so I'm
removing them.
I think there's a case to be made for removing more of
the tests because one a student has implemented logic for handling a
span of 2 they probably don't need to do any work to handle larger
spans.