-
-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated license date to 2022 #1930
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmation from legal probably required.
@@ -1,6 +1,6 @@ | |||
The MIT License (MIT) | |||
|
|||
Copyright (c) 2019 Exercism | |||
Copyright (c) 2022 Exercism |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to have a range instead of a single date. Copyright exists on original material at the time of creation, but those things that are created after the initial date, then are copyright beyond the first date. For notice of intent of enforcement of rights, then, there may be a need to correctly indicate first publication year. Since these things are not created and published at once, the range makes sense to me, even though I am not a lawyer.
I do not think we should be tossing out the earlier year as that might be deemed not on the up and up, really, since it is misleading. (Perhaps some of this information was created and even unmodified since 2013).
Like I said, I am not a lawyer, and surely not a lawyer that is familiar with the complexities of international copyright. But it does not make sense that only by changing a year, we have extended the copyright of material by another 3 years of material that would have normally come under public domain because of time passing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Kotp, Here I'm not changing terms of license it self License != Copyright, Copyright on code is renewable if we made material changes to the code and It is not strictly speaking, related to the license.
if we applied a range instead, it would be at the time of creation not the date it was published thought this isn't necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear, I did not state that the terms of license were being changed, only the notice of the copyright. I also did not indicate that licensing is copyright, it is not. The only thing changed on this line is the copyright notice. I am asking to be careful that notice is properly given if we are giving notice at all (It is not required for copyright to be in effect, in my jurisdiction).
I did say "first publication year" but I meant "first copyright event" which would be creation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, thank you for clearing that up. Now i can see that by doing so i you’d be creating an inaccurate copyright notice.
@@ -1,6 +1,6 @@ | |||
The MIT License (MIT) | |||
|
|||
Copyright (c) 2019 Exercism | |||
Copyright (c) 2022 Exercism |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An interesting read, https://techwhirl.com/updating-copyright-notices/
@ErikSchierboom Isn't the LICENSE template something we keep in org-wide-files? |
@junedev Only for tracks: https://github.com/exercism/org-wide-files/blob/main/tracks-files/LICENSE The reason for that is that non-track repos sometimes have different licenses. |
Having read the article, it looks to me that we should not be changing the year to 2022. What we could optionally do, is add it as a second date, but we'd need to consider that in a bit more details as we have hundreds of repos and I'd rather not have to manually update them all. Put in other words: do we need to do anything with the license date, or is what we current have sufficient? |
I do not think we need to do anything with it, but we might add the year that v3 went online as an additional date, since a lot of new material came in (looking at Concept exercises). I would be concerned with not notifying that some content is copyright at the earliest year, and losing that information in the notice. |
@kotp I would be okay with that. Would the license text then become:
Is that correct? |
I believe that is almost correct, and for the reasons stated, as well as the license file acknowledging that it is also a copyright notice at that location. The only problem is that the 2014 copyright notice was removed at some point, and that should still be there. So, without doing a content review, but in terms of a general overall product copyright, I would probably do:
|
I'm fine with that. @yusufadell could you update using the above suggestion? |
Closing in favor of #1945 |
Give a look at the discussion in BR #1930
* Format using prettier (exercism#1917) Format using prettier * updated description of anagrams exercise (exercism#1928) * updated description of anagrams * changed anagram description to be one-sentence-per-line * updated description of anagrams to use sets * Update Licence Give a look at the discussion in BR exercism#1930 * rational-numbers: test to reduce abs value (exercism#1938) * Change saddle point references to row, column (exercism#1948) * word-search: Add test case * Update exercises/word-search/canonical-data.json Agreed. Co-authored-by: Erik Schierboom <[email protected]> * meetup: improve descriptions by saying why each case is tested (exercism#1919) descriptions show whether a date is the first, last, or an arbitrary middle date of the week. This helps understand why certain cases are selected. Closes exercism#974 * word-search: Add cases checking for concatenation and wrapping The author of this commit thinks that concatenation is highly unlikely, but the wrapping might be useful to check in languages that allow negative indices. * `flatten-array` Add additional test cases (exercism#1953) * Add additional test cases to flatten-array * Update exercises/flatten-array/canonical-data.json Co-authored-by: Peter Tseng <[email protected]> Co-authored-by: BethanyG <[email protected]> Co-authored-by: Peter Tseng <[email protected]> * Fix bowling game copy (exercism#1955) Fixes exercism#1954 * Add action to format code (exercism#1941) * build(deps): bump DavidAnson/markdownlint-cli2-action (exercism#1952) Bumps [DavidAnson/markdownlint-cli2-action](https://github.com/DavidAnson/markdownlint-cli2-action) from 5.0.0 to 5.1.0. - [Release notes](https://github.com/DavidAnson/markdownlint-cli2-action/releases) - [Commits](DavidAnson/markdownlint-cli2-action@b3c3b40...744f913) --- updated-dependencies: - dependency-name: DavidAnson/markdownlint-cli2-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Reduced rational nr. should be in standard form. (exercism#1958) * Reduced rational should be in standard form. The current instructors fail to mention that a reduced rational number should always be rendered in standard form (without any negative value at the denominator). * remove superflous blank lines; fix wording * scale-generator: use flat and sharp symbols (exercism#1942) * Update configlet part in README (exercism#1949) Co-authored-by: ee7 <[email protected]> * phone number: only one problem per test input (exercism#1959) * [Phone Number] Only one problem per test input Because the area code is not allowed to start with 0 or 1, inputs designed to elicit other errors should not use area codes that start with either of those digits. * Respect immutability * Correct field name: s/comment/comments/ * Comments should contain a list. * Allow prettier to improve comments * book-store: reorder keys * darts: reorder keys * grade-school: reorder keys * hamming: reorder keys * high-scores: reorder keys * largest-series-product: reorder keys * list-ops: reorder keys * luhn: reorder keys * triangle: reorder keys * scale-generator: reorder keys * saddle-points: reorder keys * diffie-hellman: reorder keys * collatz-conjecture: reorder keys * anagram: reorder keys * accumulate: reorder keys * Add CI script to check correct order of keys Co-authored-by: Bart Massey <[email protected]> Co-authored-by: y8l <[email protected]> Co-authored-by: Ivan Ivanov <[email protected]> Co-authored-by: Damian C. Rossney <[email protected]> Co-authored-by: mariohuq <[email protected]> Co-authored-by: mariohuq <[email protected]> Co-authored-by: Peter Tseng <[email protected]> Co-authored-by: Peter Tseng <[email protected]> Co-authored-by: AH WEI <[email protected]> Co-authored-by: BethanyG <[email protected]> Co-authored-by: Cedd Burge <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Davide Alberto Molin <[email protected]> Co-authored-by: wolf99 <[email protected]> Co-authored-by: June <[email protected]> Co-authored-by: ee7 <[email protected]> Co-authored-by: Leah Hanson <[email protected]>
No description provided.