-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove trailing spaces #1627
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also in my opinion, canonical data hasn't changed, we should find a way to get in the whitespace repaired version without bumping...
exercises/ocr-numbers/description.md
Outdated
||_||_| | ||
||_| _| | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whitespace in this code block is significant and not allowed to be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about changing it to this?
_ _ #
| _| _| #
||_ _| #
# (blank fourth row)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With literal double crosses?
I think that would lead to similar discussion we had on another exercise where a border was drawn in the examples for visual clarification but not in the test suits for easier programmatic access... I think it was the minesweeper exercise.
Just let the whitespace where it belongs and don't add arbitrary characters which could be misinterpreted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. I reverted the changes to this file.
I have updated the initial comment. These changes may now be merged without the requirement to bump versions. The version bumps should be reversed. |
@ffflorian please include the statement |
Done, it works :) Just waiting for an answer from @NobbZ. |
I have confirmed that no JSON version change is needed
Happy New Year @NobbZ! I think @ffflorian has addressed both of the issues we had. What do you think? |
This PR will remove trailing spaces in all files. Best viewed without whitespace changes.