Add commonised JSON to scrabble score problem #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "msg": "No, 'a' scores 1 point" | ||
| }, | ||
| { | ||
| "description": "Uppercase Short input", |
|
I have a few small comments, but nothing major. Thanks! |
|
@SwamWithTurtles Any chance you'll have time to make the changes on this one? I'd love to merge it. |
IanWhitney
pushed a commit
to IanWhitney/xrust
that referenced
this pull request
May 17, 2016
Implements the Scrabble Score exercise. As of right now there is no official test suite for Scrabble Score. There is a PR (exercism/problem-specifications#161), but it is not yet merged. I've put this exercise between the Nucleotides and Roman Numerals, figuring that it did similar character iteration and value mapping. I am following the test suite in that PR, with one exception. I thought it was likely that a common naive implementation would be to map through the chars, find the score and then simply unwrap the value. Like this ``` word.chars().map(|c| values.get(&c).fold(0, |sum, v| sum + v.unwrap()) ``` So I have added a test that uses a non-English character that will cause this implementation to panic. My example implementation probably leaves a lot to be desired. I wanted to make the values hash a static, but you can't do that with a hash. ([Lazy Static](http://rust-lang-nursery.github.io/lazy-static.rs/lazy_static/index.html) does let you do this, but I'm not going to require a crate in my example).
|
I'm working on implementing this in Rust, and I've followed this proposed PR. But I added one test for the edge case of Non-English characters: https://github.com/exercism/xrust/pull/125/files#diff-26a63b91a0b305a1fd995e76a5ef5ad2R54 Though this is particularly useful in Rust (or other languages with Optional types), I can it being a useful test in other languages as well. |
|
Superseded by #255 - thanks for your work on this one @SwamWithTurtles! |
IanWhitney
pushed a commit
to IanWhitney/xrust
that referenced
this pull request
May 25, 2016
Implements the Scrabble Score exercise. As of right now there is no official test suite for Scrabble Score. There is a PR (exercism/problem-specifications#161), but it is not yet merged. I've put this exercise between the Nucleotides and Roman Numerals, figuring that it did similar character iteration and value mapping. I am following the test suite in that PR, with one exception. I thought it was likely that a common naive implementation would be to map through the chars, find the score and then simply unwrap the value. Like this ``` word.chars().map(|c| values.get(&c).fold(0, |sum, v| sum + v.unwrap()) ``` So I have added a test that uses a non-English character that will cause this implementation to panic. My example implementation probably leaves a lot to be desired. I wanted to make the values hash a static, but you can't do that with a hash. ([Lazy Static](http://rust-lang-nursery.github.io/lazy-static.rs/lazy_static/index.html) does let you do this, but I'm not going to require a crate in my example).
emcoding
pushed a commit
that referenced
this pull request
Nov 19, 2018
Pre-Push and local check setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.