Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix: Fix input string for test case 'can extract column from non-s… #1577

Closed
wants to merge 1 commit into from

Conversation

DagmarTimmreck
Copy link
Contributor

…quare matrix with no corresponding row'

@DagmarTimmreck
Copy link
Contributor Author

I am really sorry, but in the first PR #1576 there were extra spaces in the test data.

I hope I didn't break anything and apologize for the extra work.

@sshine
Copy link
Contributor

sshine commented Sep 2, 2019

I'm sorry for approving without noticing this. Thank you for putting in the extra work.

Unfortunately, we need to bump the test version once more.

@sshine
Copy link
Contributor

sshine commented Sep 3, 2019

@DagmarTimmreck: Could you push another commit that bumps the version to 1.3.0?

I would do this, but since your pull request is made from master, I cannot push changes to the pull request. If you make feature branches and create pull requests from them, maintainers of the repo you submit the pull request to can push changes, too. But as a security measure, I suppose, I cannot push to your master.

@yawpitch
Copy link
Contributor

yawpitch commented Sep 3, 2019

Got this fixed in #1578 just in case the bad whitespace was triggering an automated test build that might affect students.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants