Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve anagram problem statement #1529

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Improve anagram problem statement #1529

merged 1 commit into from
Jun 10, 2019

Conversation

gris
Copy link
Contributor

@gris gris commented Jun 10, 2019

  • Add definition of anagram
  • Improve readability

Fixes #1528

SleeplessByte
SleeplessByte reviewed Jun 10, 2019
View reviewed changes
Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think that the technical term sublist should remain.

Perhaps: Given a word and a list of candidates, select the sublist of anagrams of the given word.

@gris
Copy link
Contributor Author

gris commented Jun 10, 2019

Thanks! It makes sense to leave sublist there indeed.

SleeplessByte
SleeplessByte approved these changes Jun 10, 2019
View reviewed changes
Copy link
Member

@SleeplessByte SleeplessByte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for three ✅

However, have you seen this comment: https://github.com/joaomarcosgris/problem-specifications/commit/c7809eb1e09ff0bb40fad69f7fb5ee70a72ceead#commitcomment-33870374 @joaomarcosgris ? I think it makes sense what Maud says, but you can decide as far as I'm concerned.

cc @F3PiX @ErikSchierboom @kotp

@emcoding
Copy link
Contributor

but you can decide as far as I'm concerned.
I agree :-)

I can't add a review, but you may count me as #3 @SleeplessByte

kotp
kotp previously requested changes Jun 10, 2019
View reviewed changes
Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the wording, it suggests that the same word is not an anagram, as it must be a rearrangement of letters.

exercises/anagram/description.md Outdated Show resolved Hide resolved
@gris
Improve anagram problem statement
54a76ad 
- Add definition of anagram
- Improve readability

Fixes #1528
@SleeplessByte
Copy link
Member

Thank you @F3PiX , @kotp and @rpottsoh for the quick reviews!

This is perfect @joaomarcosgris ❤️

@SleeplessByte SleeplessByte merged commit c7a7bbc into exercism:master Jun 10, 2019
@gris gris deleted the improve-anagram-definition branch June 10, 2019 22:35
@gris gris mentioned this pull request Jun 10, 2019
Closed
petertseng pushed a commit to stringparser/rust that referenced this pull request Jun 25, 2019
@gris @petertseng
Improve anagram problem statement
29ba8eb 
- Add definition of anagram
- Improve readability

exercism/problem-specifications#1528
exercism/problem-specifications#1529
petertseng pushed a commit to petertseng/exercism-ceylon that referenced this pull request Aug 31, 2019
@gris @petertseng
anagram: improve problem statement
583fdc8 
- Add definition of anagram
- Improve readability

Fixes exercism/problem-specifications#1528

exercism/problem-specifications#1529
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotp kotp kotp left review comments

@rpottsoh rpottsoh rpottsoh approved these changes

@SleeplessByte SleeplessByte SleeplessByte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

anagram: improve description to define what is an anagram
5 participants
@gris @emcoding @SleeplessByte @kotp @rpottsoh