Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: Add instruction for exercise glyph creation #1407

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

rpottsoh
Copy link
Member

closes #1271

@rpottsoh rpottsoh self-assigned this Nov 26, 2018
Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The statement added is true and closes the issue it claims to close.

This is a step that would be good to complete before adding a new exercise.

It is unfortunate that such steps are now split between README.md and https://github.com/exercism/problem-specifications/blob/master/CONTRIBUTING.md#implementing-a-completely-new-exercise .

Since the former links to the latter, the situation is not untenable, but it's sure weird.

@cmccandless
Copy link
Contributor

cmccandless commented Nov 26, 2018

Note: while this should help cover future exercises, high-scores and dnd-character were was implemented without glyphs and still need them.

*I did not realize high-scores already had a glyph; fast work people! 🥇

@sshine
Copy link
Contributor

sshine commented Nov 26, 2018

I forgot this part for dnd-character!

Can we make a build hook fail in problem-specifications if a glyph is not there yet?

@rpottsoh
Copy link
Member Author

I believe high-scores has a glyph. I'm on my phone so don't have access to git you the sha of the commit from website-icons.

@rpottsoh
Copy link
Member Author

The glyph has nothing to do with the exercise specification so I think should not factor into the behavior of this repo.

I would agree that perhaps the site should not make an exercise available to students if there is no glyph file associated with it.

@petertseng

This comment has been minimized.

@rpottsoh rpottsoh merged commit 7e5e140 into exercism:master Nov 27, 2018
@rpottsoh rpottsoh deleted the updateREADME branch November 27, 2018 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants