darts: Add new exercise #1363

ramadis · 2018-10-09T19:34:40Z

New easy programming exercise, solved by using euclidean distance.

rpottsoh · 2018-10-09T19:47:11Z

exercises/target/canonical-data.json

+  "version": "1.0.0",
+  "cases": [
+    {
+      "description": "Retun the correct amount earnt by a dart landing in a given point in the target problem.",


While not wrong, earnt is not the common spelling, earned is the more common spelling.

rpottsoh · 2018-10-09T19:48:28Z

exercises/target/canonical-data.json

+      "cases": [
+        {
+         "property": "result",
+         "description": "A dart lands outside the targetOnly a single book",


Period and space needed between target and Only?

rpottsoh · 2018-10-09T19:49:36Z

exercises/target/canonical-data.json

+         "description": "A dart lands outside the targetOnly a single book",
+         "input": {
+           "x":15.3,
+           "y":13.2


Please have at least one space following :. Some places a space is present and in others it is absent.

rpottsoh · 2018-10-09T19:51:40Z

exercises/target/description.md

+[Darts](https://en.wikipedia.org/wiki/Darts) is a game where players
+throw darts to a [target](https://en.wikipedia.org/wiki/Darts#/media/File:Darts_in_a_dartboard.jpg).
+
+In our particular instance of the game, the target rewards with 4 different amount of points, depending on where the dart lands:


I think amount should be plural.

rpottsoh · 2018-10-09T20:22:18Z

The description depicts darts being thrown. Why not call this exercise Darts?

ramadis · 2018-10-09T20:24:50Z

Sounds good!

rpottsoh · 2018-10-09T20:30:40Z

I should have opened with this instead of nit picking... Thanks for working on this. More exercises are always welcome! No linting errors! 🥇

rpottsoh · 2018-10-09T20:35:29Z

exercises/darts/description.md

+* If the dart lands in the middle circle of the target, player earns 5 points.
+* If the dart lands in the inner circle of the target, player earns 10 points.
+
+The outer circle has a radius of 10 units (This is equivalent to the total radius for the entire target), the middle circle a radius of 5 units, and the inner circle a radius of 1. Of course, they are all centered to the same point (That is, the circles are [concentrics](http://mathworld.wolfram.com/ConcentricCircles.html)).


concentric should be singular.

rpottsoh · 2018-10-09T20:49:28Z

It is my assumption that this exercise will eventually be merged. Being a new exercise an icon will need to be created. We (you and I) do not have to worry about creating this icon. This is the responsibility of the development team. However, they will need to be notified via an issue in exercism/website-icons. Refer to #1271 for the limited conversation that has taken place on the subject. This is a new activity that we must undertake when a new exercise comes our way and so the procedure is not practiced.

At some point an issue would need to be created and this PR should be referenced. The development team can then more conveniently monitor the status of this PR to know when it has been merged or if it was closed (to know if an icon is needed).

sdublish · 2018-10-09T21:26:27Z

exercises/darts/canonical-data.json

+        },
+        {
+         "property": "result",
+         "description": "Input is not a number",


According to this, expected should be an object containing one property, error, with its value being a string describing the error.

I was thinking that any invalid input should return null. Maybe I should make it clear in the description, or go with the error. What do you think?

The convention is that an error condition should be formatted as follows: "expected": {"error": "empty stack"}
Each track implementing this exercise can then for itself decide how to represent the error case.

I think the case should be excluded from the exercise. See #902 and #523. Since erroneous input is not covered in description.md I see no reason to cover it in test data.

@ramadis What do you think about excluding this (error) case from the exercise? @rpottsoh has linked to two relevant issues.

@ErikSchierboom Yes, I'm inclined to go that way. I believe also that adding tests for inputs that are outside the problem domain in the problem specification could bring inconsistencies between implementations. Since, for example, a language with a strong type system (e.g. Haskell) shouldn't have to test for these cases since the program would not compile given incorrect input, and making it throw an exception would be counterproductive to the simplicity and core value of the problem.

So, I'll remove this test and keep going on!

ramadis · 2018-10-09T21:40:08Z

I've just opened the issue for the logo creation: exercism/website-icons#13

ErikSchierboom · 2018-10-10T06:29:03Z

exercises/darts/canonical-data.json

+        },
+        {
+         "property": "result",
+         "description": "Input is not a number",


The convention is that an error condition should be formatted as follows: "expected": {"error": "empty stack"}
Each track implementing this exercise can then for itself decide how to represent the error case.

ErikSchierboom · 2018-10-10T06:29:31Z

exercises/darts/canonical-data.json

+      "description": "Return the correct amount earned by a dart landing in a given point in the target problem.",
+      "cases": [
+        {
+         "property": "result",


Perhaps score would be a more descriptive propery name?

considerations regarding incorrect input need to be discussed.

ErikSchierboom

Just one tiny nit.

exercises/darts/canonical-data.json

rpottsoh · 2018-10-16T17:19:13Z

Minor nit pick, sorry. What is considered a Darts game? The opening sentence says to return the points earned in a Darts game. None of the tests seems to be more than a single toss. Perhaps a small rewording of the description is in order? If a single toss can constitute a game then OK. Otherwise clarification between description and canonical data is probably needed.

I am not going to revoke my approval at this point because I think this is a pretty small detail that will not likely really trip anyone up too much.

rpottsoh

👍 thanks for rewording.

rpottsoh · 2018-10-18T14:58:46Z

@sdublish do you have any more input to offer? I think otherwise this PR is about ready to be squashed and merged.

rpottsoh · 2018-10-22T18:50:32Z

This PR is going on two weeks. It has two approvals. I will plan to squash and merge in the next 24 hours unless I see good reason to hold off.

ramadis · 2018-10-22T19:09:11Z

@rpottsoh Are you squashing it or do you want me to squash the commits?

rpottsoh · 2018-10-22T19:22:40Z

You don't have to. If anyone else comes along in the mean-time it would be better for them to find things in their current state, not squashed.

sdublish · 2018-10-22T20:07:29Z

@sdublish do you have any more input to offer? I think otherwise this PR is about ready to be squashed and merged.

Sorry for not getting back to you earlier. I think it looks pretty good; one thing I would suggest is making it explicit in the description that the center of the darts board is at (0,0). While I think most people would assume that, it would still be helpful.

petertseng · 2018-10-22T20:19:08Z

Before merging, please remove .DS_Store and exercises/.DS_Store, thank you.

rpottsoh · 2018-10-23T13:22:14Z

@ramadis congrats on adding a new exercise and thanks for contributing to Exercism! 🥇

ErikSchierboom · 2018-10-23T13:31:39Z

Well done @ramadis! 🎉

Add new 'target' excercise

1b5e325

ramadis mentioned this pull request Oct 9, 2018

darts: Add new exercise exercism/javascript#498

Merged

rpottsoh reviewed Oct 9, 2018

View reviewed changes

rpottsoh changed the title ~~Add new 'target' exercise~~ target: Add new exercise Oct 9, 2018

Correct grammatical, ortographic, and style mistakes

9b5137c

ramadis changed the title ~~target: Add new exercise~~ darts: Add new exercise Oct 9, 2018

Renamed exercise to darts

dd05cfa

ramadis force-pushed the master branch from 93d1bb0 to dd05cfa Compare October 9, 2018 20:28

rpottsoh reviewed Oct 9, 2018

View reviewed changes

Fixed small typo

e7ded90

rpottsoh previously approved these changes Oct 9, 2018

View reviewed changes

sdublish suggested changes Oct 9, 2018

View reviewed changes

ramadis mentioned this pull request Oct 9, 2018

"Darts" exercise needs a logo exercism/website-icons#13

Closed

ErikSchierboom requested changes Oct 10, 2018

View reviewed changes

Fix error expected result in canonical-data.json

0d5683b

ramadis force-pushed the master branch from 2ea4525 to 0d5683b Compare October 10, 2018 14:29

Remove test for incorrect input

e486cd5

rpottsoh approved these changes Oct 16, 2018

View reviewed changes

ErikSchierboom requested changes Oct 16, 2018

View reviewed changes

exercises/darts/canonical-data.json Outdated Show resolved Hide resolved

Darts land, they don't arrive

1d56cdc

ErikSchierboom approved these changes Oct 16, 2018

View reviewed changes

Improved specificity of the description

0637a52

rpottsoh reviewed Oct 17, 2018

View reviewed changes

Explicitly say the center of the target is (0, 0)

0e67743

Remove .DS_Store

8027eb4

rpottsoh merged commit 2eb93f6 into exercism:master Oct 23, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

darts: Add new exercise #1363

darts: Add new exercise #1363

ramadis commented Oct 9, 2018

rpottsoh Oct 9, 2018 •

edited

Loading

rpottsoh Oct 9, 2018

rpottsoh Oct 9, 2018

rpottsoh Oct 9, 2018

rpottsoh commented Oct 9, 2018

ramadis commented Oct 9, 2018

rpottsoh commented Oct 9, 2018 •

edited

Loading

rpottsoh Oct 9, 2018

rpottsoh commented Oct 9, 2018

sdublish Oct 9, 2018

ramadis Oct 9, 2018

ErikSchierboom Oct 10, 2018

rpottsoh Oct 10, 2018 •

edited

Loading

ErikSchierboom Oct 16, 2018

ramadis Oct 16, 2018

ramadis commented Oct 9, 2018

ErikSchierboom Oct 10, 2018

ErikSchierboom Oct 10, 2018

ErikSchierboom left a comment

rpottsoh commented Oct 16, 2018 •

edited

Loading

rpottsoh left a comment

rpottsoh commented Oct 18, 2018

rpottsoh commented Oct 22, 2018 •

edited

Loading

ramadis commented Oct 22, 2018

rpottsoh commented Oct 22, 2018

sdublish commented Oct 22, 2018

petertseng commented Oct 22, 2018

rpottsoh commented Oct 23, 2018

ErikSchierboom commented Oct 23, 2018

darts: Add new exercise #1363

darts: Add new exercise #1363

Conversation

ramadis commented Oct 9, 2018

rpottsoh Oct 9, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rpottsoh commented Oct 9, 2018

ramadis commented Oct 9, 2018

rpottsoh commented Oct 9, 2018 • edited Loading

Choose a reason for hiding this comment

rpottsoh commented Oct 9, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rpottsoh Oct 10, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ramadis commented Oct 9, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ErikSchierboom left a comment

Choose a reason for hiding this comment

rpottsoh commented Oct 16, 2018 • edited Loading

rpottsoh left a comment

Choose a reason for hiding this comment

rpottsoh commented Oct 18, 2018

rpottsoh commented Oct 22, 2018 • edited Loading

ramadis commented Oct 22, 2018

rpottsoh commented Oct 22, 2018

sdublish commented Oct 22, 2018

petertseng commented Oct 22, 2018

rpottsoh commented Oct 23, 2018

ErikSchierboom commented Oct 23, 2018

rpottsoh Oct 9, 2018 •

edited

Loading

rpottsoh commented Oct 9, 2018 •

edited

Loading

rpottsoh Oct 10, 2018 •

edited

Loading

rpottsoh commented Oct 16, 2018 •

edited

Loading

rpottsoh commented Oct 22, 2018 •

edited

Loading