alphametics: v1.3.0 Add test for two digits carry

[omer-g]

Add test where result is longer than largest addendum by more than one
digit. In solutions that sum each digit separately this could be useful
to make sure final carry is handled correctly. For example: not
treated as a single digit.

Resolves #1342

[Insti]

Awesome, thanks @omer-g .
This sounds reasonable, and the PR looks good to me.

I'm a but rusty on the mechanics of alphametics, so it would be nice if @petertseng could run his test script over it to double check.

[petertseng]

if @petertseng could run his test script over it to double check.

that is not possible for hours or days (unknown period of time). I suggest that interested parties should run it themselves

[omer-g]

Thank you. I checked the new test case manually on several solutions in the Python track, including the example.py solution. I can try and run the script (if I'll know where to find it).

[Insti]

petertseng has a verify branch on his fork: https://github.com/petertseng/exercism-problem-specifications/blob/verify/exercises/alphametics/verify.rb

[omer-g]

Thanks. I ran the script and the tests passed.

[Insti]

Great, thanks.
One of the other maintainers will look over this and merge it sometime over the next few days.

[cmccandless]

@Insti @petertseng

Probably worth raising another issue for this (and I will if needed), but has there ever been discussion on creating a GitHub Status Check that runs @petertseng's verify scripts?

[petertseng]

discussion on creating a GitHub Status Check that runs @petertseng's verify scripts?

#460

feel free to add any additional information there if you have any

[petertseng]

clearly a useful case, with a clear description of why it is useful.

it's been > 72 hours since submission; there have been no requests for changes and there are (now including myself) two Approvals (in the GitHub sense of the word) so it seems safe to merge it.

Thanks for adding the case!