Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grains: Fixed canonical data to have standard error indicator #1322

Merged
merged 2 commits into from
Sep 13, 2018
Merged

Grains: Fixed canonical data to have standard error indicator #1322

merged 2 commits into from
Sep 13, 2018

Conversation

sdublish
Copy link
Contributor

@sdublish sdublish commented Sep 10, 2018 •
edited by rpottsoh
Loading

Fixes #1309.

Also, modified the comments so that it reflects the current state of how the error is indicated.

rpottsoh
rpottsoh approved these changes Sep 10, 2018
View reviewed changes
Copy link
Member

@rpottsoh rpottsoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rpottsoh rpottsoh merged commit 2ec42ab into exercism:master Sep 13, 2018
@rpottsoh
Copy link
Member

@sdublish thanks for helping out! 👍

@Insti Insti mentioned this pull request Sep 13, 2018
Closed
13 tasks
@sdublish sdublish deleted the issue-1309 branch September 19, 2018 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmccandless cmccandless cmccandless approved these changes

@rpottsoh rpottsoh rpottsoh approved these changes

Assignees

@sdublish sdublish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdublish @rpottsoh @cmccandless