Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wordy: Match bonus in description with canonical data #738

Closed
m-dango opened this issue Mar 24, 2017 · 2 comments
Closed

wordy: Match bonus in description with canonical data #738

m-dango opened this issue Mar 24, 2017 · 2 comments

Comments

@m-dango
Copy link
Member

m-dango commented Mar 24, 2017

The bonus mentioned for the description in wordy (i.e. 5th power) is not in the canonical data. There is cubed in the canonical data which is vaguely similar, however the case having an expected false means an error or failure is to be raised according to the canonical data description.

Any preference for which it should be?

@m-dango m-dango changed the title Match 'wordy' bonus in description with canonical data wordy: Match bonus in description with canonical data Mar 24, 2017
@petertseng
Copy link
Member

The current state of affairs doesn't seem incorrect, but it may cause two unrelated things to seem related.

The https://github.com/exercism/x-common/blob/master/exercises/wordy/description.md would say that a track might add a test such as "What is B raised to the Eth power?" and expect an answer. Even if a track were to do so, #511 and #512 told us that such a test, being a bonus, would not be included in the canonical data.

Then there is the matter of the test that is in the https://github.com/exercism/x-common/blob/master/exercises/wordy/canonical-data.json. Since the sentence "What is 52 cubed?" does not match the pattern "What is B raised to the Eth power?" nor any other known operation, it is expected to error, no matter whether a track provides a test for powers.

@petertseng
Copy link
Member

Since they are two different things, it seems OK to close.

If I were to make a possible suggestion, it is that "What is 52 cubed?" could be changed to a different question, such as "What is the square root of 9?" or something. Less confusion with powers, unless someone is considering the fractional powers.

emcoding pushed a commit that referenced this issue Nov 19, 2018
crypto-square: Reflect changes to problem specifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants