-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Fix strict types sniff #857
Conversation
I'm a little confused that the exclude isn't respected anymore. From a quick glance all errors are from
|
Well, looks like the sniff name generation has gone wrong and so the excludes are not applied for our sniff. Would you mind opening an issue at PHPCodeSniffer and report the problem? |
Note: I've not changed the `composer.json` file, but it could also be considered to leave the sniff namespace the same and to change the `"Exercism\\": "src",` config in the `composer.json` file to `"Exercism\\": "src\\Exercism",`.
The class name is already translated to a sniff name, so no need to duplicate it. Also not a good idea to use backslashes in the error code as that makes configuration in the XML file more fiddly.
…properly Properly comply with PHPCS naming conventions
It's now working ready for review. I'm personally self in doubt about the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which version of PHP CodeSniffer is required as a minimum, so that the name change works with the exclude-pattern
? This should be set in composer.json
"require-dev": { "squizlabs/php_codesniffer": "^3.11.?" }
accordingly.
3.11.1, I'll update composer.json too. |
Resolves the problem from Updating to
"squizlabs/php_codesniffer": "3.11.0"