Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve contributor experience #654

Merged
merged 12 commits into from
Mar 7, 2024
Merged

Improve contributor experience #654

merged 12 commits into from
Mar 7, 2024

Conversation

mk-mxp
Copy link
Contributor

@mk-mxp mk-mxp commented Mar 3, 2024 •
edited
Loading

Closes #620 and fixes issues with the GitHub actions workflow for PHPCS linting:

  • When a job has a strategy key, it must provide a matrix in that.
  • We don't need the PHPCS PHAR in CI anymore.

@mk-mxp mk-mxp self-assigned this Mar 3, 2024
@mk-mxp mk-mxp added x:action/improve Improve existing functionality/content x:knowledge/none No existing Exercism knowledge required x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows) x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises) x:size/medium Medium amount of work x:rep/medium Medium amount of reputation labels Mar 3, 2024
@mk-mxp mk-mxp requested a review from homersimpsons March 3, 2024 10:27
@mk-mxp mk-mxp force-pushed the improve-contributor-experience branch from e26596a to 9ea1692 Compare March 3, 2024 10:49
homersimpsons
homersimpsons reviewed Mar 3, 2024
View reviewed changes
Copy link
Contributor

@homersimpsons homersimpsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change regarding configlet are debatable. But let's do them and see if there is any negative feedback.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@mk-mxp mk-mxp force-pushed the improve-contributor-experience branch from 9ea1692 to 845574c Compare March 4, 2024 07:53
@mk-mxp mk-mxp mentioned this pull request Mar 4, 2024
Merged
1 task
@mk-mxp mk-mxp force-pushed the improve-contributor-experience branch from 845574c to 59aab70 Compare March 4, 2024 17:27
@mk-mxp mk-mxp requested a review from homersimpsons March 4, 2024 17:31
@mk-mxp mk-mxp merged commit d70c33a into exercism:main Mar 7, 2024
13 checks passed
@mk-mxp mk-mxp deleted the improve-contributor-experience branch March 7, 2024 07:51
tomasnorre pushed a commit to tomasnorre/exercism-php that referenced this pull request May 7, 2024
@mk-mxp @tomasnorre
Improve contributor experience (exercism#654)
212a922 
* Add "configlet:fmt" command
* Combine all CI tests to command "ci"
* Install / update configlet with composer packages
* Remove PHP 7.4 from 'composer.json'
* Do not run composer scripts in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@homersimpsons homersimpsons homersimpsons approved these changes

Assignees

@mk-mxp mk-mxp

Labels
x:action/improve Improve existing functionality/content x:knowledge/none No existing Exercism knowledge required x:rep/medium Medium amount of reputation x:size/medium Medium amount of work x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows) x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve contributor experience
2 participants
@mk-mxp @homersimpsons